You are not logged in.

#1 2011-05-22 18:23:41

chris-kun
Member
From: SF Bay Area
Registered: 2010-09-07
Posts: 235
Website

haskell code review?

Hey guys. Pretty new to haskell here. I've started off by writing a small command-line interface to plurk.. I was just wondering if anyone would be willing to give everything a look-over and lemme know what kinds of things I should be looking to improve upon, style-wise. Not sure I'm currently doing things in the  'haskell-way' so to speak tongue. Thanks a bunch!

https://github.com/stythys/hermes

(note: the JSON and Plurkell submodules are also mine.)

Last edited by chris-kun (2011-05-24 23:03:32)


[home page] -- [code / configs]

"Once you go Arch, you must remain there for life or else Allan will track you down and break you." -- Bregol

Offline

#2 2011-05-24 23:02:21

crabmarkjellozest
Member
Registered: 2010-07-09
Posts: 20

Re: haskell code review?

Your Github page seems to be inaccessible.

Offline

#3 2011-05-24 23:03:43

chris-kun
Member
From: SF Bay Area
Registered: 2010-09-07
Posts: 235
Website

Re: haskell code review?

modified link


[home page] -- [code / configs]

"Once you go Arch, you must remain there for life or else Allan will track you down and break you." -- Bregol

Offline

#4 2011-05-27 15:45:30

listdata
Member
Registered: 2008-12-23
Posts: 102
Website

Re: haskell code review?

That's a lot of code --- two suggestions:

(1) Use CmdArgs for robust command line argument handling, and (2) check out the HLint tool for automated code sanity checks.

Offline

Board footer

Powered by FluxBB