Arch Linux

starfry

Member

From: Surrey, UK

Registered: 2010-08-18

Posts: 238

AUR package update: request for review

Hi,
I've been doing a bit of work on my system recently and a few AUR packages I need are out of date and unmaintained. I've updated the PKGBUILDS and installed locally but I'd like to upload them for others and am happy to maintain these packages in the absence of anyone else.

I've never uploaded to AUR so I'd appreciate some checking of what I'm doing.

The packages in question are:
1. pyzor
2. clamassassin
3. dcc

I've already requested to be the maintainer of these and note my name now shows as the maintainer. My first package to try updating is pyzor and the revised PKGBUILD is below

# Maintainer: Starfry  <archlinux@jelmail.com>

pkgname=pyzor
pkgver=0.5.0
pkgrel=2
pkgdesc="Detect and block spam using identifying digests of messages."
arch=('x86_64')
url="http://pyzor.sourceforge.net/"
license=('GPL')
depends=('python2')
source=(http://downloads.sourceforge.net/sourceforge/pyzor/$pkgname-$pkgver.tar.bz2)
md5sums=('21f5ed92470ab12a7658cc46bf59a3e9')

build() {
  cd $startdir/src/$pkgname-$pkgver
  python2 setup.py install --root=$startdir/pkg
}

The changes in this instance were to make it use "python2" and I updated the pkgrel from 1 to 2.

I've done "makepkg --source" to get a tarball and I have "pyzor-0.5.0-2-src.tar.gz" ready to go. It contains only the PKGBUILD.

Before I upload this and before I do any of the others, am I doing this right and is there anything else i need to do ?

jomasti

Member

From: USA

Registered: 2010-08-17

Posts: 96

Re: AUR package update: request for review

Yes, that is right, since you have no other files to include in the source archive since there is no install file, patches, etc. It should be good to upload.

falconindy

Developer

From: New York, USA

Registered: 2009-10-22

Posts: 4,111

Website

Re: AUR package update: request for review

Do not use $startdir/src. It is not equivalent to the more proper "$srcdir" (with quotes). Also, since you have nothing to build, rename your build function 'package'.

---

blog | ±github

starfry

Member

From: Surrey, UK

Registered: 2010-08-18

Posts: 238

Re: AUR package update: request for review

ok, I'll make those changes. I did just inherit the PKGBUILD from the previous maintainer but I will take the opportunity to make the improvements.

birdflesh

Member

From: Greece

Registered: 2010-08-04

Posts: 97

Re: AUR package update: request for review

Also, I believe that this should have arch=('any')

doorknob60

Member

Registered: 2008-09-29

Posts: 404

Re: AUR package update: request for review

And similarly to changing $startdir/src, to $srcdir, you should also change $startdir/pkg to $pkgdir, and also the arch should probably be 'any', not 'x86_64' (unless for some reason this is for 64 bit systems only? I doubt that)

starfry

Member

From: Surrey, UK

Registered: 2010-08-18

Posts: 238

Re: AUR package update: request for review

submitted update. hopefully I've done it right