DWM Hackers Unite! Share (or request) dwm patches.

Thuban · 2011-09-17 12:11:02

Guys, you really should consider to add your patches here:
http://dwm.suckless.org/patches/
and talking about them on the list :
dev@suckless.org

Because here, reading 12 pages is so confusing, and it's a pity regarding the great work there is!

JokerBoy · 2011-09-17 13:11:09

http://ompldr.org/vYWUzbQ/pertag2-nbstack.diff pertag2 with simon's version of nbstack.

also, the patch that I use is just simon's pertag2 version with a segfault fix on "reload" and which adds a new layout ntile without removing the tile layout.

Last edited by JokerBoy (2011-09-18 17:01:36)

beepressure · 2011-09-18 15:34:36

JokerBoy wrote:

beepressure wrote:
Is it because im trying to patch it on 5.9.2? Totally clean, no patches. In fact I copied the stuff from abs all over so it was fresh.
pertag2 for dwm-5.9.
What 5.9.2 are you using, the latest version in hg repo is 5.9.1. Maybe you are trying to say arch package 5.9-2, but then it should work fine.

Yeah youre right. It's 5.9-2

mhertz · 2011-09-18 15:58:17

@JokerBoy

Thanks alot, mate! It's very much appreciated!

@beepresure

I was using just the newest tarbal from suckless.org i.e. 5.9... I prefer to not install it, but just configure/compile it under ~/.builds, and copy the binary to ~/.bin and run it from there in .xinitrc...

Last edited by mhertz (2011-09-18 16:02:43)

Ypnose · 2011-09-18 17:01:12

And what about a pertag2 version with gaplessgrid, please Jokerboy?

Last edited by Ypnose (2011-09-18 20:48:40)

mhertz · 2011-09-18 20:19:20

I myself got errors during the building of dwm with the gapplessgrid.c file from suckless.org on a prepatched pertag source, so I just handpatched it into dwm.c instead.

You can then diff it to a vanilla dwm, and you've got the combined patch for latter usage...

Just add the function to dwm.c and declare it under '/* function declarations */' i.e.

static void gaplessgrid(Monitor *m);

Btw, totally off-topic, but many ppl dosen't seem to know that you can just use standard color name strings in config.h instead of the color codes i.e. blue, white black etc, and the same with fonts, where you can use e.g. 7x14, instead of the longer variants...

..I'm playing with dwm currently, and I fully understand why so many of you fellow archers favor this wm...

Last edited by mhertz (2011-09-18 20:32:35)

JokerBoy · 2011-09-18 20:58:27

Ypnose wrote:

And what about a pertag2 version with gaplessgrid, please Jokerboy?

you can use: http://hg.punctweb.ro/dwm/src/a3465e7ad … sgrid.diff
and don't forget to add "{ "[G]", True, gaplessgrid }," to your config.h

and sorry, ATM I'm using windows in order to flash my blackberry.

Last edited by JokerBoy (2011-09-20 07:24:04)

Ypnose · 2011-09-19 09:44:31

Yes, I saw your personal patch ( gaplessgrid.diff ) but it needs cycle.diff and for me this patch isn't necessary.

That's why I asked it but dude, take your time.

iEugene · 2011-09-19 17:47:04

Ypnose wrote:

Yes, I saw your personal patch ( gaplessgrid.diff ) but it needs cycle.diff and for me this patch isn't necessary.
That's why I asked it but dude, take your time.

Try this: http://ompldr.org/vYWY5YQ/05-gaplessgrid.diff.

beepressure · 2011-09-19 18:08:56

mhertz wrote:

@beepresure
I was using just the newest tarbal from suckless.org i.e. 5.9... I prefer to not install it, but just configure/compile it under ~/.builds, and copy the binary to ~/.bin and run it from there in .xinitrc...

edit: disregard first part

I will try this

Last edited by beepressure (2011-09-19 18:11:30)

karol · 2011-09-19 18:12:06

beepressure wrote:

mhertz wrote:
@beepresure
I was using just the newest tarbal from suckless.org i.e. 5.9... I prefer to not install it, but just configure/compile it under ~/.builds, and copy the binary to ~/.bin and run it from there in .xinitrc...
I dont quite follow all the way. Doesnt compiling it=installing?

Not exactly: 'make' = compiling, 'make install' = installing. You have to run 'make' but you can copy (or even symlink) stuff by hand.

beepressure · 2011-09-19 18:27:45

karol wrote:

beepressure wrote:
mhertz wrote:
@beepresure
I was using just the newest tarbal from suckless.org i.e. 5.9... I prefer to not install it, but just configure/compile it under ~/.builds, and copy the binary to ~/.bin and run it from there in .xinitrc...
I dont quite follow all the way. Doesnt compiling it=installing?
Not exactly: 'make' = compiling, 'make install' = installing. You have to run 'make' but you can copy (or even symlink) stuff by hand.

Yeah I realized that as soon as i posted the reply, hah. Well I got the vanilla tarball from suckless, compiled, patched, and edited config.h by adding "static const int nmaster = 1; /* clients in the master area */" Did, another make and got these errors.

[al@boddicker dwm-5.9]$ make
dwm build options:
CFLAGS   = -std=c99 -pedantic -Wall -Os -I. -I/usr/include -I/usr/include/X11/ -DVERSION="5.9" -DXINERAMA
LDFLAGS  = -s -L/usr/lib -lc -L/usr/lib/X11 -lX11 -L/usr/lib/X11 -lXinerama
CC       = cc
CC dwm.c
dwm.c: In function ‘buttonpress’:
dwm.c:450:9: error: request for member ‘name’ in something not a structure or union
dwm.c:450:9: error: request for member ‘name’ in something not a structure or union
dwm.c: In function ‘createmon’:
dwm.c:688:29: error: request for member ‘mfact’ in something not a structure or union
dwm.c:688:61: error: request for member ‘mfact’ in something not a structure or union
dwm.c:689:31: error: request for member ‘nmaster’ in something not a structure or union
dwm.c:689:67: error: request for member ‘nmaster’ in something not a structure or union
dwm.c:690:26: error: request for member ‘layout’ in something not a structure or union
dwm.c: In function ‘drawbar’:
dwm.c:769:10: error: request for member ‘name’ in something not a structure or union
dwm.c:769:10: error: request for member ‘name’ in something not a structure or union
dwm.c:771:19: error: request for member ‘name’ in something not a structure or union
dwm.c: At top level:
dwm.c:2111:1: warning: ‘incnmaster’ defined but not used [-Wunused-function]
dwm.c:2119:1: warning: ‘ntile’ defined but not used [-Wunused-function]
make: *** [dwm.o] Error 1
[al@boddicker dwm-5.9]$

basically same errors as when i was using the ABS build

mhertz · 2011-09-19 22:33:08

The pertag2 patch needs specific additional definitions to be manually added into config.h, of where you've entered one of them, but there needs more, which you can see from e.g. jokerboy's config.h.

I don't use pertag2, as I don't really need the extra things added on-top of original pertag from suckless.org, and hence, I cannot show you mine examples, but e.g. in jokerboy's config.h, he has this:

/* tagging */
static const Tag tags[] = {
        /* name       layout           mfact    nmaster */
        { "main",     &layouts[4],     -1,      -1 },
        { "term",     &layouts[4],     -1,      -1 },
        { "web",      &layouts[2],     -1,      -1 },
        { "im",       &layouts[6],     0.17,    -1 },
        { "misc",     &layouts[4],     -1,      -1 },
};

Which you of-course needs to adapt to yours, and you also need to add ntile layout, and incrmaster shortcuts etc. Again, check out jokerboy's config.h for those...

Last edited by mhertz (2011-09-19 22:39:57)

beepressure · 2011-09-20 01:04:37

Ok, so you CAN use the pertag 5.8.2 for dwm 5.9? I was under the impression that pertag2 was made for 5.9. I too, dont wanna use the extras so I guess i'll just try to one from suckless

JokerBoy · 2011-09-20 07:29:20

Ypnose wrote:

And what about a pertag2 version with gaplessgrid, please Jokerboy?

http://ompldr.org/vYWZtNg/02-dwm-5.9-gaplessgrid.diff

also, you should start learning how to apply a patch by hand. is quite easy.

Ypnose · 2011-09-20 09:36:20

JokerBoy wrote:

http://ompldr.org/vYWZtNg/02-dwm-5.9-gaplessgrid.diff
also, you should start learning how to apply a patch by hand. is quite easy.

Yeah. You're right. I'll do that next time.
Anyway thank you.

iEugene: You were pretty fast. Thanks a lot, man.

mhertz · 2011-09-20 22:46:11

beepressure wrote:

Ok, so you CAN use the pertag 5.8.2 for dwm 5.9? I was under the impression that pertag2 was made for 5.9. I too, dont wanna use the extras so I guess i'll just try to one from suckless

Yes, pertag patch from suckless.org works fine on dwm 5.9. The version number of the patches is just used as a reference from which it will 100% work, and then for latter versions you just need to test for yourself if it still works!

Pertag2 was made to expand functionality by including e.g. nbalanced and such, but not for compatibility reasons.

I used to use alot of patches, but as I thought about it, then I actually didn't need all those extra additions anyway, so now I just use 3 patches; pertag, bstack and gaplessgrid, from suckless.org, and of those only gaplessgrid was problematic, so I handpatched it into dwm.c and made a patch of it for latter usage.

Last edited by mhertz (2011-09-21 18:16:51)

beepressure · 2011-09-22 04:53:26

I have 5.9 with pertag and bstack working.

mhertz · 2011-09-23 14:50:45

JokerBoy wrote:

[,,,]
also, the patch that I use is just simon's pertag2 version with a segfault fix on "reload" and which adds a new layout ntile without removing the tile layout.

Hi JokerBoy.

Could you please ellaborate upon what that "reload" segfault means? I mean in what circumstances could it appear to segfault?

I have come to really like the pertag2 with nbstack.c from simon, but as it is somewhat old, and especially because of youre remark above, then I was woried about if it in some case is unstable i.e. the segfault you describe, allthough I haven't encountered anything weird in the last day or so where i've been using it.

Btw, the reason that I don't just use your version, is that I preffer to have the nmaster functionality non-greedy like simon's pertag2(as it includes nbalanced), but it seems you've changed that to a greedy ntile... Also, I don't use both tile/ntile, but just the ntile(and nbstack), which when non-greedy and set to 2 masters works pretty nice imho...

Note, this isn't a "please make me a patch" kinda post, but just a theoretical question about what the "reload" segfault means? If it's something that could possibly affect me, then I can just diff your version to simons and hopefully be able to find the fix you've made...

Thanks in advance.

Last edited by mhertz (2011-09-23 14:54:50)

JokerBoy · 2011-09-23 15:02:12

Hi,

If you start dwm by using this, when you "reload" a segfault will appear in your dmesg but that's 'cause m->mfacts[0], m->nmasters[0] and m->lts[0] aren't set to defaults in createmon(). I reported this behaviour but it seems that nobody cares any more. I have been using this patch for months now and it's very stable, at least for me.

mhertz · 2011-09-23 15:07:11

Ahh, of course! Obviously that's what the "reload" means! Sorry for being dence!

Thanks alot for your reply and help on your pertag2 segfault fix! Much appreciated!

CU, Martin.

inch · 2011-09-23 16:51:09

Hello, I'm in deep need of a grid mode patch for 5.9, is there something yet?

Ypnose · 2011-09-23 17:13:50

Don't know if it's the right place but what about dwm and dual-screens? Someone have feedback about it?

steve___ · 2011-09-23 17:20:38

dwm supports multiple screens. As for feedback I suggest you just try it. dwm is very subjective.

mhertz · 2011-09-24 00:23:21

inch wrote:

Hello, I'm in deep need of a grid mode patch for 5.9, is there something yet?

Even though it dosen't say for dwm-5.9, then check anyway as it still might work, and if it dosen't, then try to handpatch it, as it's maybe a pertag interference issue like with gaplessgrid(never had the need for using "gapped" grid myself, so dunno).

For gaplessgrid, then JokerBoy has a patch for v5.9, but it depends on some other patch(es) to be present to work, I believe it's cycle if I remember right, but again, it's just a function and a function declaration to be added to dwm.c.

Arch Linux

#301 2011-09-17 12:11:02

Re: DWM Hackers Unite! Share (or request) dwm patches.

#302 2011-09-17 13:11:09

Re: DWM Hackers Unite! Share (or request) dwm patches.

#303 2011-09-18 15:34:36

Re: DWM Hackers Unite! Share (or request) dwm patches.

#304 2011-09-18 15:58:17

Re: DWM Hackers Unite! Share (or request) dwm patches.

#305 2011-09-18 17:01:12

Re: DWM Hackers Unite! Share (or request) dwm patches.

#306 2011-09-18 20:19:20

Re: DWM Hackers Unite! Share (or request) dwm patches.

#307 2011-09-18 20:58:27

Re: DWM Hackers Unite! Share (or request) dwm patches.

#308 2011-09-19 09:44:31

Re: DWM Hackers Unite! Share (or request) dwm patches.

#309 2011-09-19 17:47:04

Re: DWM Hackers Unite! Share (or request) dwm patches.

#310 2011-09-19 18:08:56

Re: DWM Hackers Unite! Share (or request) dwm patches.

#311 2011-09-19 18:12:06

Re: DWM Hackers Unite! Share (or request) dwm patches.

#312 2011-09-19 18:27:45

Re: DWM Hackers Unite! Share (or request) dwm patches.

#313 2011-09-19 22:33:08

Re: DWM Hackers Unite! Share (or request) dwm patches.

#314 2011-09-20 01:04:37

Re: DWM Hackers Unite! Share (or request) dwm patches.

#315 2011-09-20 07:29:20

Re: DWM Hackers Unite! Share (or request) dwm patches.

#316 2011-09-20 09:36:20

Re: DWM Hackers Unite! Share (or request) dwm patches.

#317 2011-09-20 22:46:11

Re: DWM Hackers Unite! Share (or request) dwm patches.

#318 2011-09-22 04:53:26

Re: DWM Hackers Unite! Share (or request) dwm patches.

#319 2011-09-23 14:50:45

Re: DWM Hackers Unite! Share (or request) dwm patches.

#320 2011-09-23 15:02:12

Re: DWM Hackers Unite! Share (or request) dwm patches.

#321 2011-09-23 15:07:11

Re: DWM Hackers Unite! Share (or request) dwm patches.

#322 2011-09-23 16:51:09

Re: DWM Hackers Unite! Share (or request) dwm patches.

#323 2011-09-23 17:13:50

Re: DWM Hackers Unite! Share (or request) dwm patches.

#324 2011-09-23 17:20:38

Re: DWM Hackers Unite! Share (or request) dwm patches.

#325 2011-09-24 00:23:21

Re: DWM Hackers Unite! Share (or request) dwm patches.

Board footer