want to change /etc/profile

milaxnuts · 2020-10-07 07:49:34

hello bbs

i want to send a patch for /etc/profile

i want to replace these six lines

# Append our default paths
appendpath () {
    case ":$PATH:" in
        *:"$1":*)
            ;;
        *)
            PATH="${PATH:+$PATH:}$1"
    esac
}

with this one line

# Append our default paths
appendpath () {
    [[ ":$PATH:" != *":$1:"* ]] && PATH="${PATH:+$PATH:}$1"
}

now ....

$ pacman -Qo /etc/profile
/etc/profile is owned by filesystem 2020.05.07-1

$ pacman -Qi filesystem | grep http
URL             : https://www.archlinux.org

questions

1. where is the source code of package filesystem?
2. where do i send the patch?

eschwartz · 2020-10-07 08:00:55

Why should this patch be accepted? What's the inherent advantage of it?

Your function produces a failing return code, by the way. It is also invalid syntax for various /bin/sh shells that don't implement [[

/etc/profile is NOT bash.

GaKu999 · 2020-10-07 08:02:10

That’s a bashism, it looks like that because it’s (and must be) POSIX...

Edit: argh @eschwartz beated me

Last edited by GaKu999 (2020-10-07 08:02:47)

fukawi2 · 2020-10-07 12:01:08

milaxnuts wrote:

1. where is the source code of package filesystem?

https://git.archlinux.org/svntogit/pack … nk/profile

milaxnuts wrote:

2. where do i send the patch?

https://bugs.archlinux.org/

Others have already explained why a patch for this is *extremely* unlikely to be accepted, and you've not explained why it should either.

milaxnuts · 2020-10-07 18:44:27

eschwartz wrote:

It is also invalid syntax for various /bin/sh shells that don't implement [[
/etc/profile is NOT bash.

that is a killer argument : /

GaKu999 wrote:

it looks like that because it’s (and must be) POSIX...

thanks for answering my hidden question

Last edited by milaxnuts (2020-10-07 19:05:33)

milaxnuts · 2020-10-08 05:42:47

lets just ask some shells, how they like my pretty code

#!/bin/bash

s=$(cat <<'EOF'
#!/bin/sh
[[ 1 == 1 ]] && echo y
EOF
)

bash -c "$s"
# -> y

dash -c "$s"
# -> dash: 2: [[: not found
# rc = 127

posh -c "$s"
# -> posh: [[: not found
# rc = 127

ash and mrsh will probably give the same answer

shellcheck.net says: SC3010: In POSIX sh, [[ ]] is undefined.

related: How can I test for POSIX compliance of shell scripts?

Arch Linux

#1 2020-10-07 07:49:34

want to change /etc/profile

#2 2020-10-07 08:00:55

Re: want to change /etc/profile

#3 2020-10-07 08:02:10

Re: want to change /etc/profile

#4 2020-10-07 12:01:08

Re: want to change /etc/profile

#5 2020-10-07 18:44:27

Re: want to change /etc/profile

#6 2020-10-08 05:42:47

Re: want to change /etc/profile

Board footer