You are not logged in.

#1 2022-04-19 21:11:50

seamusdemora
Member
Registered: 2020-04-09
Posts: 15

How to submit a patch or pull request for dhcpcd

I've found a fix for a long-standing bug in dhcpcd. How do I submit a patch - or a pull request for it?


-----

The trouble with the world is that the stupid are cocksure, and the intelligent are full of doubt.
~ Bertrand Russell

Offline

#2 2022-04-19 21:19:16

Slithery
Forum Moderator
From: Norfolk, UK
Registered: 2013-12-01
Posts: 5,241

Re: How to submit a patch or pull request for dhcpcd

If this is an upstream bug then report it upstream. If it's a packaging bug then use the Arch bugtracker.


No, it didn't "fix" anything. It just shifted the brokeness one space to the right. - jasonwryan
Closing -- for deletion; Banning -- for muppetry. - jasonwryan

aur - dotfiles

Online

#3 2022-04-19 21:38:23

seamusdemora
Member
Registered: 2020-04-09
Posts: 15

Re: How to submit a patch or pull request for dhcpcd

It has been reported "upstream", but dhcpcd author says this doesn't help downstreams update dhcpcd. But you guys have it covered, I'm sure.


-----

The trouble with the world is that the stupid are cocksure, and the intelligent are full of doubt.
~ Bertrand Russell

Offline

#4 2022-04-19 22:22:19

Slithery
Forum Moderator
From: Norfolk, UK
Registered: 2013-12-01
Posts: 5,241

Re: How to submit a patch or pull request for dhcpcd

Has 'upstream' released a new version including your patch yet?
Please link to it if they have as I can't see anything....
https://wiki.archlinux.org/title/Arch_Linux#Modernity


No, it didn't "fix" anything. It just shifted the brokeness one space to the right. - jasonwryan
Closing -- for deletion; Banning -- for muppetry. - jasonwryan

aur - dotfiles

Online

#5 2022-04-20 00:33:55

loqs
Member
Registered: 2014-03-06
Posts: 14,702

Re: How to submit a patch or pull request for dhcpcd

Is it this pull for the dhcpcd-8 branch?  https://github.com/NetworkConfiguration/dhcpcd/pull/95

Offline

#6 2022-04-29 22:26:55

seamusdemora
Member
Registered: 2020-04-09
Posts: 15

Re: How to submit a patch or pull request for dhcpcd

loqs wrote:

Is it this pull for the dhcpcd-8 branch?  https://github.com/NetworkConfiguration/dhcpcd/pull/95

Yes - that's it. I recalled that Arch used dhcpcd, but didn't know which version. My PR was for the version (8.1) currently used in the 'OS formerly known as Raspbian'. There was another PR for ver 9.


-----

The trouble with the world is that the stupid are cocksure, and the intelligent are full of doubt.
~ Bertrand Russell

Offline

#7 2022-04-29 22:36:30

seamusdemora
Member
Registered: 2020-04-09
Posts: 15

Re: How to submit a patch or pull request for dhcpcd

Slithery wrote:

Has 'upstream' released a new version including your patch yet?
Please link to it if they have as I can't see anything....
https://wiki.archlinux.org/title/Arch_Linux#Modernity


Here's the [link to #47](https://github.com/NetworkConfiguration … /issues/47) against ver 9.


-----

The trouble with the world is that the stupid are cocksure, and the intelligent are full of doubt.
~ Bertrand Russell

Offline

#8 2022-04-29 22:50:52

progandy
Member
Registered: 2012-05-17
Posts: 4,874

Re: How to submit a patch or pull request for dhcpcd

Arch linux uses the latest stable version, which is 9.4.1 and already includes the fix for infinite informs.
(You do not have to guess, a search in the package database is enough: https://archlinux.org/packages/?q=dhcpcd )

Last edited by progandy (2022-04-29 22:51:46)


| alias CUTF='LANG=en_XX.UTF-8@POSIX ' |

Offline

Board footer

Powered by FluxBB