[SOLVED] Can you tell me why this segfaults?

Trilby · 2012-06-12 22:11:06

Awesome, right documentation page, just wrong part of it. See my edit above.

Exploring those doc pages should help polish this project off.

Unia · 2012-06-12 22:15:41

Trilby wrote:

Awesome, right documentation page, just wrong part of it. See my edit above.
Exploring those doc pages should help polish this project off.

Okay, as I said I will look into this tomorrow.

jdarnold · 2012-06-13 14:27:44

I really recommend the free ebook "C++: A Dialog" (it used to be called "Who's Afraid of C++?"). You can find it here:

http://www.steveheller.com/cppad/cppad.htm

It really goes from beginner to expert, as he discusses programming with a complete newbie.

Unia · 2012-06-13 14:55:12

jdarnold wrote:

I really recommend the free ebook "C++: A Dialog" (it used to be called "Who's Afraid of C++?"). You can find it here:
http://www.steveheller.com/cppad/cppad.htm
It really goes from beginner to expert, as he discusses programming with a complete newbie.

Thanks! But.. is C++ alot different than C?

Unia · 2012-06-13 17:35:02

Unia wrote:

Okay, as I said I will look into this tomorrow.

I am doing so at the moment but still can't get it to work Trilby, the code you suggested, e.g.

struct mpd_status *mystatus = mpd_recv_status(conn);

doesn't change a thing. Do I have to add something else? I already tried lots of things and am also spitting through those document pages I found, but yea... can't get it to work. Here's what I have atm:

...
struct mpd_status *mystatus = mpd_recv_status(conn);
if (mystatus == MPD_STATE_PLAY) {
            mpd_response_next(conn);

            song = mpd_recv_song(conn);

            if ((title = g_markup_escape_text(mpd_song_get_tag(song, MPD_TAG_TITLE, 0), -1)) == NULL)
                title = TEXT_UNKNOWN;
            if ((artist = g_markup_escape_text(mpd_song_get_tag(song, MPD_TAG_ARTIST, 0), -1)) == NULL)
                artist = TEXT_UNKNOWN;
            if ((album = g_markup_escape_text(mpd_song_get_tag(song, MPD_TAG_ALBUM, 0), -1)) == NULL)
                album = TEXT_UNKNOWN;

            notification = (char *) malloc(strlen(TEXT_PLAY) + strlen(title) + strlen(artist) + strlen(album));
            sprintf(notification, TEXT_PLAY, title, artist, album);

            mpd_song_free(song);
}
else if (mystatus == MPD_STATE_PAUSE) {
            notification = (char *) malloc(strlen(TEXT_PAUSE));
            sprintf(notification, TEXT_PAUSE);
}
        else {
            notification = (char *) malloc(strlen(TEXT_STOP));
            sprintf(notification, TEXT_STOP);
        }
...

ewaller · 2012-06-13 21:57:46

Unia wrote:

...
struct mpd_status *mystatus = mpd_recv_status(conn);
if (mystatus == MPD_STATE_PLAY) {
            mpd_response_next(conn);
...

You are comparing a state to a status. You need to compare states to states. You get the state using mpd_status_get_state and passing in the status ... Only after you know the status is valid.

I refer you to a quote from my previous post:

 struct mpd_status* theStatus = mpd_recv_status(conn);
 if ( ! theStatus)
   /*Don't use a null pointer.  You may want a more graceful error handler */
  exit(1);
if (mpd_status_get_state(theStatus) == MPD_STATE_PLAY)
{

Edit: Fixed two minor code issues. It is a struct, not a typedef.

Last edited by ewaller (2012-06-13 21:59:55)

Unia · 2012-06-15 13:56:14

Sorry for not replying yesterday. I got to hear I passed my finals at High School so I was busy celebrating with friends and family (In case you wonder now, I'm 17 years old)

Today I fiddled around with the code a tad and suddenly got it working! I don't know how 'efficient' it is but at least it works!

In case anyone wants to use it too (or review the code ) here it is:
https://gist.github.com/2936589

ewaller · 2012-06-15 14:34:12

That is a whole lot more complex than the code I was writing when I was your age. Well Done.

And, far more importantly, congratulations on the exams.

(Yikes, you are my daughter's age )

Unia · 2012-06-15 14:34:47

ewaller wrote:

That is a whole lot more complex than the code I was writing when I was your age. Well Done.
And, far more importantly, congratulations on the exams.
(Yikes, you are my daughter's age )

Thanks! And eh... got an email? (joking, of course )

Arch Linux

#26 2012-06-12 22:11:06

Re: [SOLVED] Can you tell me why this segfaults?

#27 2012-06-12 22:15:41

Re: [SOLVED] Can you tell me why this segfaults?

#28 2012-06-13 14:27:44

Re: [SOLVED] Can you tell me why this segfaults?

#29 2012-06-13 14:55:12

Re: [SOLVED] Can you tell me why this segfaults?

#30 2012-06-13 17:35:02

Re: [SOLVED] Can you tell me why this segfaults?

#31 2012-06-13 21:57:46

Re: [SOLVED] Can you tell me why this segfaults?

#32 2012-06-15 13:56:14

Re: [SOLVED] Can you tell me why this segfaults?

#33 2012-06-15 14:34:12

Re: [SOLVED] Can you tell me why this segfaults?

#34 2012-06-15 14:34:47

Re: [SOLVED] Can you tell me why this segfaults?

Board footer