You are not logged in.

#1 2015-04-21 18:44:46

minimalm
Member
From: Juneau, AK
Registered: 2011-09-08
Posts: 23
Website

First PKGBUILD for review

Hello, since this is the first package I've created, I thought it would be best to have it reviewed before submitting it to the AUR.

Thank you!

PKGBUILD:

# Maintainer: Jeremey Hustman <jeremeyhustman at gmail daught com>

pkgname=cflint-git
_gitname=CFLint
pkgver=CFLint.0.4.release.r21.d446a95
pkgrel=1
pkgdesc="A static code analysis tool for ColdFusion"
url=https://github.com/cflint/CFLint/wiki
arch=(any)
license=('(L)GPL3')
depends=()
makedepends=('git' 'maven')
conflicts=($_gitname)
provides=($_gitname)
noextract=()
source=("git://github.com/cflint/${_gitname}.git")
md5sums=('SKIP')

pkgver() {
	cd "$_gitname"
	# Git, tags available
	printf "%s" "$(git describe --long | sed 's/\([^-]*-\)g/r\1/;s/-/./g')"
}

build() {
	if [ -d "${_gitname}" ]; then
		cd "$_gitname"
		git clean -dfx
		git reset --hard
		git pull origin master
	else
		git clone "${_gitroot}"
		cd "${_gitname}"
	fi
	mvn clean install
}

package() {
	cd "${srcdir}/${_gitname}"
	mkdir -p ${pkgdir}/{usr/bin,usr/etc,usr/lib}
	pwd
	install -Dm755 target/appassembler/bin/* "${pkgdir}/usr/bin/"
	install -Dm644 target/appassembler/etc/* "${pkgdir}/usr/etc/"
	install -Dm644 target/appassembler/lib/* "${pkgdir}/usr/lib/"
}

Offline

#2 2015-04-22 00:12:20

Scimmia
Fellow
Registered: 2012-09-01
Posts: 11,465

Re: First PKGBUILD for review

First off, the entire if/else block in the build function is not only unnecessary but counter productive. Get rid of it.

What is the pwd command in the package function for?

You did well with quoting in general, but missed the mkdir command.

I would suggest cleaning up the pkgver a bit. You really don't want it to start with "CFLint", for example.

Online

#3 2015-04-22 00:31:58

jasonwryan
Anarchist
From: .nz
Registered: 2009-05-09
Posts: 30,424
Website

Re: First PKGBUILD for review

...and you can remove the empty arrays (depends, noextract).


Arch + dwm   •   Mercurial repos  •   Surfraw

Registered Linux User #482438

Offline

#4 2015-04-22 02:49:56

Scimmia
Fellow
Registered: 2012-09-01
Posts: 11,465

Re: First PKGBUILD for review

Also, I don't think that license entry is valid.

Online

#5 2015-04-22 08:32:26

Freso
Member
From: Denmark
Registered: 2011-09-09
Posts: 42
Website

Re: First PKGBUILD for review

And it should conflict and provide "cflint", not "CFlint".


Machines: Kotake. Tael, Farore
PKGBUILDs: in AUR, at BitBucket

Offline

#6 2015-04-22 16:11:56

minimalm
Member
From: Juneau, AK
Registered: 2011-09-08
Posts: 23
Website

Re: First PKGBUILD for review

Thank you all, I appreciate your input!

Offline

#7 2015-04-22 16:27:25

minimalm
Member
From: Juneau, AK
Registered: 2011-09-08
Posts: 23
Website

Re: First PKGBUILD for review

Scimmia, that pwd was to make sure that I was where I though I was, debugging code that got left behind.

Offline

#8 2015-04-23 08:32:44

fukawi2
Ex-Administratorino
From: .vic.au
Registered: 2007-09-28
Posts: 6,217
Website

Re: First PKGBUILD for review

Moving to "Creating & Modifying Packages"

Offline

Board footer

Powered by FluxBB