You are not logged in.

#1 2015-11-30 01:21:15

blainester
Member
Registered: 2014-11-26
Posts: 6

Made my first PKGBUILD. Please tell me what I did wrong.

It works on my system using makepkg -s but as this is my first PKGBUILD I know there are things I'm doing wrong. Please tell me so I can fix them!

https://github.com/blainester/AUR/blob/ … s/PKGBUILD

Thank you in advance!

Offline

#2 2015-11-30 01:29:36

Trilby
Inspector Parrot
Registered: 2011-11-29
Posts: 29,447
Website

Re: Made my first PKGBUILD. Please tell me what I did wrong.

Looks pretty good.  I'm not sure how I feel about the package name - vcs would generally be assumed to be related to version control systems.  Also, you are listing the wrong license: LGPL != GPL.


"UNIX is simple and coherent..." - Dennis Ritchie, "GNU's Not UNIX" -  Richard Stallman

Offline

#3 2015-11-30 01:40:02

blainester
Member
Registered: 2014-11-26
Posts: 6

Re: Made my first PKGBUILD. Please tell me what I did wrong.

I agree with the package name, but felt something like video-contact-sheet was too verbose when the actual script is called using 'vcs'. Should I change it anyway?

Fixed the license too, thanks.

Offline

#4 2015-11-30 04:11:46

Scimmia
Fellow
Registered: 2012-09-01
Posts: 11,466

Re: Made my first PKGBUILD. Please tell me what I did wrong.

Only issue I see is with quoting. Whenever you're using a variable that you don't control, like $srcdir and $pkgdir, you should use quotation marks in case the paths include spaces.

Offline

#5 2015-11-30 04:38:19

fukawi2
Ex-Administratorino
From: .vic.au
Registered: 2007-09-28
Posts: 6,217
Website

Re: Made my first PKGBUILD. Please tell me what I did wrong.

Looks pretty good. Where is the config file supposed to live? /etc/vcs.conf? I would probably install the example there, and add it to the backup() array.

Offline

Board footer

Powered by FluxBB