You are not logged in.

#1 2006-09-10 19:08:34

karsten
Member
Registered: 2006-07-14
Posts: 261

edit the #includes in a source .c file during makepkg?

is this legal/whatever? i'm trying to build a package where their includes say

include gtk/whatever.h

well make fails because it doesn't find whatever.h, but i found if i edit the line to just say

include whatever.h

then it will find it.. so what should i do?

thanks for any help.
karsten

[edit-code posting filter]

Offline

#2 2006-09-10 19:26:59

chrismortimore
Member
From: Edinburgh, UK
Registered: 2006-07-15
Posts: 655

Re: edit the #includes in a source .c file during makepkg?

It is legal (assuming it is GPL) as long as you give credit to the original author for the work they did.  Or don't publish it, whichever wink

EDIT: But out of courtesy, you should contact the original author and tell them about it.


Desktop: AMD Athlon64 3800+ Venice Core, 2GB PC3200, 2x160GB Maxtor DiamondMax 10, 2x320GB WD Caviar RE, Nvidia 6600GT 256MB
Laptop: Intel Pentium M, 512MB PC2700, 60GB IBM TravelStar, Nvidia 5200Go 64MB

Offline

#3 2006-09-10 19:35:53

tomk
Forum Fellow
From: Ireland
Registered: 2004-07-21
Posts: 9,839

Re: edit the #includes in a source .c file during makepkg?

While you're at it, make a patch. The dev will be happy to get it, and you can also use it in your PKGBUILD, until it's fixed upstream.

Offline

#4 2006-09-10 20:39:47

karsten
Member
Registered: 2006-07-14
Posts: 261

Re: edit the #includes in a source .c file during makepkg?

tomk wrote:

While you're at it, make a patch...

that's what i was thinking.  it could just be an incompatibility between arch's file locations and they distro they built it on, say red hat right? thanks

Offline

#5 2006-09-10 20:42:25

chrismortimore
Member
From: Edinburgh, UK
Registered: 2006-07-15
Posts: 655

Re: edit the #includes in a source .c file during makepkg?

karsten wrote:

that's what i was thinking.  it could just be an incompatibility between arch's file locations and they distro they built it on, say red hat right? thanks

Possible.  If I were you, make the patch, and send it to the author and say "This is needed to install it on Arch", and set the PKGBUILD to use your patch.


Desktop: AMD Athlon64 3800+ Venice Core, 2GB PC3200, 2x160GB Maxtor DiamondMax 10, 2x320GB WD Caviar RE, Nvidia 6600GT 256MB
Laptop: Intel Pentium M, 512MB PC2700, 60GB IBM TravelStar, Nvidia 5200Go 64MB

Offline

Board footer

Powered by FluxBB