edit the #includes in a source .c file during makepkg?

karsten · 2006-09-10 19:08:34

is this legal/whatever? i'm trying to build a package where their includes say

include gtk/whatever.h

well make fails because it doesn't find whatever.h, but i found if i edit the line to just say

include whatever.h

then it will find it.. so what should i do?

thanks for any help.
karsten

[edit-code posting filter]

chrismortimore · 2006-09-10 19:26:59

It is legal (assuming it is GPL) as long as you give credit to the original author for the work they did. Or don't publish it, whichever

EDIT: But out of courtesy, you should contact the original author and tell them about it.

tomk · 2006-09-10 19:35:53

While you're at it, make a patch. The dev will be happy to get it, and you can also use it in your PKGBUILD, until it's fixed upstream.

karsten · 2006-09-10 20:39:47

tomk wrote:

While you're at it, make a patch...

that's what i was thinking. it could just be an incompatibility between arch's file locations and they distro they built it on, say red hat right? thanks

chrismortimore · 2006-09-10 20:42:25

karsten wrote:

that's what i was thinking. it could just be an incompatibility between arch's file locations and they distro they built it on, say red hat right? thanks

Possible. If I were you, make the patch, and send it to the author and say "This is needed to install it on Arch", and set the PKGBUILD to use your patch.

Arch Linux

#1 2006-09-10 19:08:34

edit the #includes in a source .c file during makepkg?

#2 2006-09-10 19:26:59

Re: edit the #includes in a source .c file during makepkg?

#3 2006-09-10 19:35:53

Re: edit the #includes in a source .c file during makepkg?

#4 2006-09-10 20:39:47

Re: edit the #includes in a source .c file during makepkg?

#5 2006-09-10 20:42:25

Re: edit the #includes in a source .c file during makepkg?

Board footer