You are not logged in.
Hello,
I am trying to connect a DualShock 4 controller via USB, which is expected to work out of the box (Gamepad#PlayStation_3/4_controller).
The controller is recognised by the system at some level, but is not usable.
When connecting, an error appears in the ring buffer:
$ sudo dmesg
[ 113.191499] usb 2-1.5: USB disconnect, device number 3
[ 116.729588] usb 2-1.5: new full-speed USB device number 4 using ehci-pci
[ 116.830226] usb 2-1.5: New USB device found, idVendor=054c, idProduct=05c4, bcdDevice= 1.00
[ 116.830230] usb 2-1.5: New USB device strings: Mfr=1, Product=2, SerialNumber=0
[ 116.830233] usb 2-1.5: Product: Wireless controller
[ 116.830234] usb 2-1.5: Manufacturer: Sony Computer Entertainment
[ 121.945175] sony 0003:054C:05C4.0006: failed to retrieve feature report 0x81 with the DualShock 4 MAC address
[ 121.945305] sony 0003:054C:05C4.0006: hidraw4: USB HID v81.00 Gamepad [Sony Computer Entertainment Wireless controller] on usb-0000:00:1d.0-1.5/input0
[ 121.945308] sony 0003:054C:05C4.0006: failed to claim inputThe controller is listed by lusb:
$ lsusb
Bus 002 Device 002: ID 8087:0024 Intel Corp. Integrated Rate Matching Hub
Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 006 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 005 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 001 Device 005: ID 04d9:4545 Holtek Semiconductor, Inc. Keyboard [Diatec Majestouch 2 Tenkeyless]
Bus 001 Device 004: ID 046d:c083 Logitech, Inc. G403 Prodigy Gaming Mouse
Bus 001 Device 006: ID 046d:0892 Logitech, Inc. OrbiCam
Bus 001 Device 003: ID 0424:2514 Microchip Technology, Inc. (formerly SMSC) USB 2.0 Hub
Bus 001 Device 002: ID 8087:0024 Intel Corp. Integrated Rate Matching Hub
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 004 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 003 Device 002: ID 054c:05c4 Sony Corp. DualShock 4 [CUH-ZCT1x]
Bus 003 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hubHowever, there is no js* device in /dev/input/ and a scan of the event* files does not reveal the controller:
$ sudo evtest
No device specified, trying to scan all of /dev/input/event*
Available devices:
/dev/input/event0: Power Button
/dev/input/event1: Power Button
/dev/input/event2: Logitech G403 Prodigy Gaming Mouse
/dev/input/event3: Logitech G403 Prodigy Gaming Mouse Keyboard
/dev/input/event4: Logitech G403 Prodigy Gaming Mouse Consumer Control
/dev/input/event5: Logitech G403 Prodigy Gaming Mouse System Control
/dev/input/event6: USB Keyboard
/dev/input/event7: USB Keyboard Consumer Control
/dev/input/event8: USB Keyboard System Control
/dev/input/event9: PC Speaker
/dev/input/event10: HD Pro Webcam C920
/dev/input/event11: HDA NVidia HDMI/DP,pcm=3
/dev/input/event12: HDA NVidia HDMI/DP,pcm=7
/dev/input/event13: HDA NVidia HDMI/DP,pcm=8
/dev/input/event14: HDA NVidia HDMI/DP,pcm=9
/dev/input/event15: HDA NVidia HDMI/DP,pcm=10
/dev/input/event16: HDA NVidia HDMI/DP,pcm=11
/dev/input/event17: HDA NVidia HDMI/DP,pcm=12
/dev/input/event18: HDA Intel PCH Front Mic
/dev/input/event19: HDA Intel PCH Rear Mic
/dev/input/event20: HDA Intel PCH Line
/dev/input/event21: HDA Intel PCH Line Out Front
/dev/input/event22: HDA Intel PCH Line Out Surround
/dev/input/event23: HDA Intel PCH Line Out CLFE
/dev/input/event24: HDA Intel PCH Front HeadphoneI have checked that both the usbhid and joydev modules are loaded (see Gamepad#Determining_which_modules_you_need):
$ lsmod | grep usbhid
usbhid 65536 0
$ lsmod | grep joydev
joydev 28672 0As shown, these modules are listed as unused, even after connecting the controller.
What I have tried: pressing the PS button; restarting the system; using a different the usb cable.
Any suggestions on how to troubleshoot this issue and get the controller to correctly appear in /dev/input/ would be appreciated.
Last edited by piperfw (2023-02-05 06:16:13)
Offline
A friend has since lent me a DualShock 4 controller (which came with his console) and this worked immediately without the below error (A DualShock 3 controller worked too).
I suspect the controller I bought was not a genuine Sony product and have now returned it (it works in Windows, but I guess people cloning the product didn't think about Linux).
A Ubuntu user saw exactly the same error and had reason to believe his controller was counterfeit.
I am marking the the issue as [Solved]; hopefully anyone else who see this error will question the hardware and not waste time troubleshooting.
Offline
For what it's worth, I've found a patch online that might solve your issue (which is, by the way, an issue that I have too).
https://www.mail-archive.com/linux-kern … 40145.html
In case of link rot, I'll copy-paste the patch here:
Signed-off-by: Ivan Mironov <mironov.i...@gmail.com>
---
drivers/hid/hid-sony.c | 72 ++++++++++++++++++++++++++++++------------
1 file changed, 52 insertions(+), 20 deletions(-)
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index e3a557dc9ffd..97df12180e45 100644
--- a/drivers/hid/hid-sony.c
+++ b/drivers/hid/hid-sony.c
@@ -491,6 +491,7 @@ struct motion_output_report_02 {
#define DS4_FEATURE_REPORT_0x02_SIZE 37
#define DS4_FEATURE_REPORT_0x05_SIZE 41
+#define DS4_FEATURE_REPORT_0x12_SIZE 16
#define DS4_FEATURE_REPORT_0x81_SIZE 7
#define DS4_FEATURE_REPORT_0xA3_SIZE 49
#define DS4_INPUT_REPORT_0x11_SIZE 78
@@ -2593,6 +2594,53 @@ static int sony_get_bt_devaddr(struct sony_sc *sc)
return 0;
}
+static int sony_get_usb_ds4_devaddr(struct sony_sc *sc)
+{
+ u8 *buf = NULL;
+ int ret;
+
+ buf = kmalloc(max(DS4_FEATURE_REPORT_0x12_SIZE,
DS4_FEATURE_REPORT_0x81_SIZE), GFP_KERNEL);
+ if (!buf)
+ return -ENOMEM;
+
+ /*
+ * The MAC address of a DS4 controller connected via USB can be
+ * retrieved with feature report 0x81. The address begins at
+ * offset 1.
+ */
+ ret = hid_hw_raw_request(sc->hdev, 0x81, buf,
+ DS4_FEATURE_REPORT_0x81_SIZE, HID_FEATURE_REPORT,
+ HID_REQ_GET_REPORT);
+ if (ret == DS4_FEATURE_REPORT_0x81_SIZE) {
+ memcpy(sc->mac_address, &buf[1], sizeof(sc->mac_address));
+ goto out_free;
+ }
+ dbg_hid("%s: hid_hw_raw_request(..., 0x81, ...) returned %d\n",
__func__, ret);
+
+ /*
+ * Some variants do not implement feature report 0x81 at all.
+ * Fortunately, feature report 0x12 also contains the MAC address of
+ * a controller.
+ */
+ ret = hid_hw_raw_request(sc->hdev, 0x12, buf,
+ DS4_FEATURE_REPORT_0x12_SIZE, HID_FEATURE_REPORT,
+ HID_REQ_GET_REPORT);
+ if (ret == DS4_FEATURE_REPORT_0x12_SIZE) {
+ memcpy(sc->mac_address, &buf[1], sizeof(sc->mac_address));
+ goto out_free;
+ }
+ dbg_hid("%s: hid_hw_raw_request(..., 0x12, ...) returned %d\n",
__func__, ret);
+
+ hid_err(sc->hdev, "failed to retrieve feature reports 0x81 and 0x12
with the DualShock 4 MAC address\n");
+ ret = ret < 0 ? ret : -EINVAL;
+
+out_free:
+
+ kfree(buf);
+
+ return ret;
+}
+
static int sony_check_add(struct sony_sc *sc)
{
u8 *buf = NULL;
@@ -2613,26 +2661,9 @@ static int sony_check_add(struct sony_sc *sc)
return 0;
}
} else if (sc->quirks & (DUALSHOCK4_CONTROLLER_USB |
DUALSHOCK4_DONGLE)) {
- buf = kmalloc(DS4_FEATURE_REPORT_0x81_SIZE, GFP_KERNEL);
- if (!buf)
- return -ENOMEM;
-
- /*
- * The MAC address of a DS4 controller connected via USB can be
- * retrieved with feature report 0x81. The address begins at
- * offset 1.
- */
- ret = hid_hw_raw_request(sc->hdev, 0x81, buf,
- DS4_FEATURE_REPORT_0x81_SIZE,
HID_FEATURE_REPORT,
- HID_REQ_GET_REPORT);
-
- if (ret != DS4_FEATURE_REPORT_0x81_SIZE) {
- hid_err(sc->hdev, "failed to retrieve feature report
0x81 with the DualShock 4 MAC address\n");
- ret = ret < 0 ? ret : -EINVAL;
- goto out_free;
- }
-
- memcpy(sc->mac_address, &buf[1], sizeof(sc->mac_address));
+ ret = sony_get_usb_ds4_devaddr(sc);
+ if (ret < 0)
+ return ret;
snprintf(sc->hdev->uniq, sizeof(sc->hdev->uniq),
"%pMR", sc->mac_address);
@@ -2670,6 +2701,7 @@ static int sony_check_add(struct sony_sc *sc)
return 0;
}
+ dbg_hid("%s: retrieved MAC address: %s\n", __func__, sc->hdev->uniq);
ret = sony_check_add_dev_list(sc);
out_free:
--I am not attempting to patch the kernel, but if someone encounters the same problem and they are motivated enough, this information could be useful.
Also note that the author of the above patch is working on a better one https://www.mail-archive.com/linux-kern … 77531.html
Offline
I tried this patch on the hid-sony module and it worked fine
Last edited by rakhenmanoa (2021-12-07 04:55:05)
Offline
I tried this patch on the hid-sony module and it worked fine
can you please post the patch file you used I am trying to patch the hid-sony.c from the patch file above and it is failing
patch hid-sony.c < hid-sony.diff
patching file hid-sony.c
Hunk #1 succeeded at 478 (offset -13 lines).
patch: **** malformed patch at line 28: DS4_FEATURE_REPORT_0x81_SIZE), GFP_KERNEL); I tired patch this module on github
https://github.com/soreau/hid-sony.git
and if you are patching the hid-sony.c on official linux git repo and than can you please leave instruction how you managed to do that
Offline
@nibirrayy, FYI, I fixed patch (shown below; watch out for wrapped lines caused by the forum renderer), but my 3rd-party clone controller apparently doesn't have 0x12 reporting either, which this patch falls back to when 0x81 fails.
failed to retrieve feature reports 0x81 and 0x12 with the DualShock 4 MAC addressMaybe it'll work for you.
--- a/drivers/hid/hid-sony.c 2021-12-21 22:16:46.190024249 -0500
+++ b/drivers/hid/hid-sony.c 2021-12-21 22:30:16.048986978 -0500
@@ -504,6 +504,7 @@
#define DS4_FEATURE_REPORT_0x02_SIZE 37
#define DS4_FEATURE_REPORT_0x05_SIZE 41
+#define DS4_FEATURE_REPORT_0x12_SIZE 16
#define DS4_FEATURE_REPORT_0x81_SIZE 7
#define DS4_FEATURE_REPORT_0xA3_SIZE 49
#define DS4_INPUT_REPORT_0x11_SIZE 78
@@ -2593,6 +2594,55 @@
return 0;
}
+static int sony_get_usb_ds4_devaddr(struct sony_sc *sc)
+{
+ u8 *buf = NULL;
+ int ret;
+
+ buf = kmalloc(max(DS4_FEATURE_REPORT_0x12_SIZE, DS4_FEATURE_REPORT_0x81_SIZE), GFP_KERNEL);
+ if (!buf)
+ return -ENOMEM;
+
+ /*
+ * The MAC address of a DS4 controller connected via USB can be
+ * retrieved with feature report 0x81. The address begins at
+ * offset 1.
+ */
+ ret = hid_hw_raw_request(sc->hdev, 0x81, buf,
+ DS4_FEATURE_REPORT_0x81_SIZE, HID_FEATURE_REPORT,
+ HID_REQ_GET_REPORT);
+ if (ret == DS4_FEATURE_REPORT_0x81_SIZE) {
+ memcpy(sc->mac_address, &buf[1], sizeof(sc->mac_address));
+ goto out_free;
+ }
+ dbg_hid("%s: hid_hw_raw_request(..., 0x81, ...) returned %d\n", __func__, ret);
+
+ /*
+ * Some variants do not implement feature report 0x81 at all.
+ * Fortunately, feature report 0x12 also contains the MAC address of
+ * a controller.
+ */
+ ret = hid_hw_raw_request(sc->hdev, 0x12, buf,
+ DS4_FEATURE_REPORT_0x12_SIZE, HID_FEATURE_REPORT,
+ HID_REQ_GET_REPORT);
+ if (ret == DS4_FEATURE_REPORT_0x12_SIZE) {
+ memcpy(sc->mac_address, &buf[1], sizeof(sc->mac_address));
+ goto out_free;
+ }
+ dbg_hid("%s: hid_hw_raw_request(..., 0x12, ...) returned %d\n", __func__, ret);
+
+ hid_err(sc->hdev, "failed to retrieve feature reports 0x81 and 0x12 with the DualShock 4 MAC address\n");
+ ret = ret < 0 ? ret : -EINVAL;
+
+out_free:
+
+ kfree(buf);
+
+ return ret;
+}
+
+
+
static int sony_check_add(struct sony_sc *sc)
{
u8 *buf = NULL;
@@ -2613,26 +2663,9 @@
return 0;
}
} else if (sc->quirks & (DUALSHOCK4_CONTROLLER_USB | DUALSHOCK4_DONGLE)) {
- buf = kmalloc(DS4_FEATURE_REPORT_0x81_SIZE, GFP_KERNEL);
- if (!buf)
- return -ENOMEM;
-
- /*
- * The MAC address of a DS4 controller connected via USB can be
- * retrieved with feature report 0x81. The address begins at
- * offset 1.
- */
- ret = hid_hw_raw_request(sc->hdev, 0x81, buf,
- DS4_FEATURE_REPORT_0x81_SIZE, HID_FEATURE_REPORT,
- HID_REQ_GET_REPORT);
-
- if (ret != DS4_FEATURE_REPORT_0x81_SIZE) {
- hid_err(sc->hdev, "failed to retrieve feature report 0x81 with the DualShock 4 MAC address\n");
- ret = ret < 0 ? ret : -EINVAL;
- goto out_free;
- }
-
- memcpy(sc->mac_address, &buf[1], sizeof(sc->mac_address));
+ ret = sony_get_usb_ds4_devaddr(sc);
+ if (ret < 0)
+ return ret;
snprintf(sc->hdev->uniq, sizeof(sc->hdev->uniq),
"%pMR", sc->mac_address);
@@ -2670,6 +2703,7 @@
return 0;
}
+ dbg_hid("%s: retrieved MAC address: %s\n", __func__, sc->hdev->uniq);
ret = sony_check_add_dev_list(sc);
out_free:The original patch author Ivan Mironov said he was working on a better patch, but I can't find it anywhere.
Last edited by tklee (2021-12-22 04:05:14)
Offline
@nibirrayy here's the patch I used :
--- a/drivers/hid/hid-sony.c
+++ b/drivers/hid/hid-sony.c
@@ -491,6 +491,7 @@ struct motion_output_report_02 {
#define DS4_FEATURE_REPORT_0x02_SIZE 37
#define DS4_FEATURE_REPORT_0x05_SIZE 41
+#define DS4_FEATURE_REPORT_0x12_SIZE 16
#define DS4_FEATURE_REPORT_0x81_SIZE 7
#define DS4_FEATURE_REPORT_0xA3_SIZE 49
#define DS4_INPUT_REPORT_0x11_SIZE 78
@@ -2593,6 +2594,53 @@ static int sony_get_bt_devaddr(struct sony_sc *sc)
return 0;
}
+static int sony_get_usb_ds4_devaddr(struct sony_sc *sc)
+{
+ u8 *buf = NULL;
+ int ret;
+
+ buf = kmalloc(max(DS4_FEATURE_REPORT_0x12_SIZE, DS4_FEATURE_REPORT_0x81_SIZE), GFP_KERNEL);
+ if (!buf)
+ return -ENOMEM;
+
+ /*
+ * The MAC address of a DS4 controller connected via USB can be
+ * retrieved with feature report 0x81. The address begins at
+ * offset 1.
+ */
+ ret = hid_hw_raw_request(sc->hdev, 0x81, buf,
+ DS4_FEATURE_REPORT_0x81_SIZE, HID_FEATURE_REPORT,
+ HID_REQ_GET_REPORT);
+ if (ret == DS4_FEATURE_REPORT_0x81_SIZE) {
+ memcpy(sc->mac_address, &buf[1], sizeof(sc->mac_address));
+ goto out_free;
+ }
+ dbg_hid("%s: hid_hw_raw_request(..., 0x81, ...) returned %d\n", __func__, ret);
+
+ /*
+ * Some variants do not implement feature report 0x81 at all.
+ * Fortunately, feature report 0x12 also contains the MAC address of
+ * a controller.
+ */
+ ret = hid_hw_raw_request(sc->hdev, 0x12, buf,
+ DS4_FEATURE_REPORT_0x12_SIZE, HID_FEATURE_REPORT,
+ HID_REQ_GET_REPORT);
+ if (ret == DS4_FEATURE_REPORT_0x12_SIZE) {
+ memcpy(sc->mac_address, &buf[1], sizeof(sc->mac_address));
+ goto out_free;
+ }
+ dbg_hid("%s: hid_hw_raw_request(..., 0x12, ...) returned %d\n", __func__, ret);
+
+ hid_err(sc->hdev, "failed to retrieve feature reports 0x81 and 0x12 with the DualShock 4 MAC address\n");
+ ret = ret < 0 ? ret : -EINVAL;
+
+out_free:
+
+ kfree(buf);
+
+ return ret;
+}
+
static int sony_check_add(struct sony_sc *sc)
{
u8 *buf = NULL;
@@ -2613,26 +2661,9 @@ static int sony_check_add(struct sony_sc *sc)
return 0;
}
} else if (sc->quirks & (DUALSHOCK4_CONTROLLER_USB | DUALSHOCK4_DONGLE)) {
- buf = kmalloc(DS4_FEATURE_REPORT_0x81_SIZE, GFP_KERNEL);
- if (!buf)
- return -ENOMEM;
-
- /*
- * The MAC address of a DS4 controller connected via USB can be
- * retrieved with feature report 0x81. The address begins at
- * offset 1.
- */
- ret = hid_hw_raw_request(sc->hdev, 0x81, buf,
- DS4_FEATURE_REPORT_0x81_SIZE, HID_FEATURE_REPORT,
- HID_REQ_GET_REPORT);
-
- if (ret != DS4_FEATURE_REPORT_0x81_SIZE) {
- hid_err(sc->hdev, "failed to retrieve feature report 0x81 with the DualShock 4 MAC address\n");
- ret = ret < 0 ? ret : -EINVAL;
- goto out_free;
- }
-
- memcpy(sc->mac_address, &buf[1], sizeof(sc->mac_address));
+ ret = sony_get_usb_ds4_devaddr(sc);
+ if (ret < 0)
+ return ret;
snprintf(sc->hdev->uniq, sizeof(sc->hdev->uniq),
"%pMR", sc->mac_address);
@@ -2670,6 +2701,7 @@ static int sony_check_add(struct sony_sc *sc)
return 0;
}
+ dbg_hid("%s: retrieved MAC address: %s\n", __func__, sc->hdev->uniq);
ret = sony_check_add_dev_list(sc);
out_free:
Offline
For anyone else that also got here just now, there's a
hid-sony-panic-fix-dkms package on AUR package to "fix" (workaround actually) this.
@see https://aur.archlinux.org/packages/hid- … c-fix-dkms
Offline
Thanks all for the continued input on this topic. I've updated the title to better reflect the ongoing discussion.
Offline
My clone DS4 was suffering from the same USB bug and 'hid-sony-panic-fix-dkms' indeed solved the problem.
But I noticed another one that may be related, if I try to use ds4drv(-cemuhook) with this controller in hidraw mode via bluetooth, ds4drv crashes with this output:
$ ds4drv --hidraw
[info][controller 1] Created devices /dev/input/js1 (joystick) /dev/input/event19 (evdev)
Traceback (most recent call last):
File "/usr/bin/ds4drv", line 33, in <module>
sys.exit(load_entry_point('ds4drv==0.5.1', 'console_scripts', 'ds4drv')())
File "/usr/lib/python3.10/site-packages/ds4drv/__main__.py", line 192, in main
for device in backend.devices:
File "/usr/lib/python3.10/site-packages/ds4drv/backends/hidraw.py", line 172, in devices
yield cls(name=device_name,
File "/usr/lib/python3.10/site-packages/ds4drv/backends/hidraw.py", line 34, in __init__
super(HidrawDS4Device, self).__init__(name, addr, type)
File "/usr/lib/python3.10/site-packages/ds4drv/device.py", line 84, in __init__
self.set_operational()
File "/usr/lib/python3.10/site-packages/ds4drv/backends/hidraw.py", line 87, in set_operational
self.read_feature_report(0x02, 37)
File "/usr/lib/python3.10/site-packages/ds4drv/backends/hidraw.py", line 63, in read_feature_report
return fcntl.ioctl(self.fd, op, bytes(buf))
OSError: [Errno 5] Input/output error
Without --hidraw it works, but need to pair again at each use.
Someone have this problem as well?
(Sorry if my english is bad, not my native language)
Last edited by Kl01 (2023-03-01 02:11:11)
Offline
The kernel 6.2 introduced some changes related to Sony controllers, and it seems to be working fine now without the dkms workaround
Offline