You are not logged in.

#1 2009-09-15 16:22:18

helpvampire
Member
Registered: 2009-08-10
Posts: 32

makepkg bug

If you try to build a package inside a folder that has a space in the name the build fails.

Can someone please report it as I don't have a arch bug tracker account.

Thanks.

Offline

#2 2009-09-15 16:24:34

Allan
Pacman
From: Brisbane, AU
Registered: 2007-06-09
Posts: 11,672
Website

Re: makepkg bug

Create an account then...  but there really is no need.  This definitely does work as long as the PKGBUILD always uses $srcdir and $pkgdir in quotes.

Offline

#3 2009-09-15 19:48:14

helpvampire
Member
Registered: 2009-08-10
Posts: 32

Re: makepkg bug

In that case the AUR packaging standards need to be updated because most PKGBUILDs do not put $srcdir and $pkgdir in quotes.

Offline

#4 2009-09-15 22:48:00

Daenyth
Forum Fellow
From: Boston, MA
Registered: 2008-02-24
Posts: 1,244

Re: makepkg bug

More to the point though, can pacman handle packages with a space in the name? I know I've never seen one, and I doubt anyone would want to. Why does your package need a space?

Offline

#5 2009-09-15 22:55:53

ngoonee
Forum Fellow
From: Between Thailand and Singapore
Registered: 2009-03-17
Posts: 7,362

Re: makepkg bug

OP is talking about 'building inside a folder with a space in the name', by which he's referring to the path I guess.

pacman -U works fine, though I've never seen a package with a space in the file-name itself, I've -U from a package which was on a path with a space in the name.


Allan-Volunteer on the (topic being discussed) mailn lists. You never get the people who matters attention on the forums.
jasonwryan-Installing Arch is a measure of your literacy. Maintaining Arch is a measure of your diligence. Contributing to Arch is a measure of your competence.
Griemak-Bleeding edge, not bleeding flat. Edge denotes falls will occur from time to time. Bring your own parachute.

Offline

#6 2009-09-15 23:38:20

Allan
Pacman
From: Brisbane, AU
Registered: 2007-06-09
Posts: 11,672
Website

Re: makepkg bug

I've never tested a space in the "pkgname" var.   My guess is it does not work...  Spaces in source file names should work.

helpvampire wrote:

In that case the AUR packaging standards need to be updated because most PKGBUILDs do not put $srcdir and $pkgdir in quotes.

The prototype in /usr/share/pacman does use quotes.  However, even many official packages don't because no-one really cares about this.

Offline

#7 2009-09-15 23:55:45

ngoonee
Forum Fellow
From: Between Thailand and Singapore
Registered: 2009-03-17
Posts: 7,362

Re: makepkg bug

Yes, I was under the impression that spaces in your directory path would break plenty of stuff. Just say no, when the paths in question are to be used for anything other than user data, in other words, everything outside /home


Allan-Volunteer on the (topic being discussed) mailn lists. You never get the people who matters attention on the forums.
jasonwryan-Installing Arch is a measure of your literacy. Maintaining Arch is a measure of your diligence. Contributing to Arch is a measure of your competence.
Griemak-Bleeding edge, not bleeding flat. Edge denotes falls will occur from time to time. Bring your own parachute.

Offline

#8 2009-09-16 17:40:52

helpvampire
Member
Registered: 2009-08-10
Posts: 32

Re: makepkg bug

Save a PKGBUILD in a folder called "Build folder" and try to build it.

Offline

#9 2009-09-16 23:16:52

Allan
Pacman
From: Brisbane, AU
Registered: 2007-06-09
Posts: 11,672
Website

Re: makepkg bug

Your point being?  makepkg can handle it provided the PKGBUILD is quotes the relevant variables.  Problem is, no-one cars enough to do that...

Offline

#10 2009-09-17 02:02:25

fukawi2
Ex-Administratorino
From: .vic.au
Registered: 2007-09-28
Posts: 6,237
Website

Re: makepkg bug

helpvampire wrote:

Save a PKGBUILD in a folder called "Build folder" and try to build it.

Spaces are traditionally not used in paths for exactly this reason. Regardless, Alan is right. It's not makepkg that's broken, it's the syntax of the PKGBUILD's you're using.

I'd suggest you'll have a hard time getting this "fixed" since:
1) you'll have to file a bug against every single package that doesn't quote the variable in the PKGBUILD; and
2) this seems to be the first time anyone has wanted to use a build directory with a space in the name....

Probably going to take even longer if you won't make yourself an account on the bug tracker and want someone else to do all the reporting for you wink

Last edited by fukawi2 (2009-09-17 02:03:06)

Offline

#11 2009-09-17 12:03:24

helpvampire
Member
Registered: 2009-08-10
Posts: 32

Re: makepkg bug

Here's plan:

1. Wait untill 3.00 am.
2. Hack AUR and get root access.
3. Dissable AUR submissions.
4. Run script to decompress the PKGBUILDs, add quotes to the variables using sed, then recompress them.
5. Re-enable AUR submissions.
6. Edit Wiki AUR packaging standards page to require all variables be quoted.

Also thought of plan for getting 1000000000 USD while I was making the first plan.

1. Wait untill 3.00 am.
2. Hack AUR and get root access.
3. Dissable AUR submissions.
4. Move all the PKGBUILDs onto usb flash drive.
5. Tie some string onto the flash drive.
6. Tie the other end of the string to a bridge with water underneath.
7. Put sharks into the water under the bridge.
8. Steal some nukular missiles.
9. Aim the nukular missiles at the string.
10. Hold the PKGBUILDs for ransom for 1000000000 USD.

Offline

#12 2009-09-17 15:52:53

ngoonee
Forum Fellow
From: Between Thailand and Singapore
Registered: 2009-03-17
Posts: 7,362

Re: makepkg bug

Someone would need to care about this.

I doubt anyone would. Spaces in file/directory names are the evil step-child of Unix filesystems, we can deal with them, but everyone would rather they didn't exist.

The PKGBUILDs in question just aren't kind enough to care smile.


Allan-Volunteer on the (topic being discussed) mailn lists. You never get the people who matters attention on the forums.
jasonwryan-Installing Arch is a measure of your literacy. Maintaining Arch is a measure of your diligence. Contributing to Arch is a measure of your competence.
Griemak-Bleeding edge, not bleeding flat. Edge denotes falls will occur from time to time. Bring your own parachute.

Offline

#13 2009-09-17 22:39:47

fukawi2
Ex-Administratorino
From: .vic.au
Registered: 2007-09-28
Posts: 6,237
Website

Re: makepkg bug

helpvampire wrote:

1. Wait untill 3.00 am.

Who's 3.00am? Your 3.00am is probably right when I am using the AUR.

Why would we take down the AUR and do a mass change of all the packages just because 1 person doesn't want to rename their build directory from "Build Dir" to "BuildDir" or "Build_Dir"?

Last edited by fukawi2 (2009-09-17 22:40:52)

Offline

Board footer

Powered by FluxBB